chore: resource registry #85
Open
+3,286
−875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarioCadenas
force-pushed
the
resource-registry
branch
from
b7f9199 to
ff847ee
Compare
MarioCadenas
force-pushed
the
resource-registry
branch
from
ec151bd to
f3aca2e
Compare
pkosiec
approved these changes
Feb 10, 2026
Member
pkosiec
left a comment
pkosiec
left a comment
There was a problem hiding this comment.
Overal LGTM, two small comments - please check them and address them (if applicable) here or in a follow-up PR 👍
| @@ -15,7 +15,16 @@ interface ReconnectStreamResponse { | |||
|
|
|||
| export class ReconnectPlugin extends Plugin { | |||
| public name = "reconnect"; | |||
Member
There was a problem hiding this comment.
BTW - do we need the public name for plugins if it's already in the static manifest? Or is it like an instance name which should vary when you instantiate the class multiple times?
Member
There was a problem hiding this comment.
Can we extract resource collection and validation to some separate methods? The logic here a bit makes it harder to read the high-level logic for registering plugins.
Like it was before:
pluginInstance.validateEnv();so now I can imagine, we'd have two calls: validation + collecting resources
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Stack (3/3)
📝 Changes
b7f9199chore: resource registry📖 About this stack
This PR is part of a stack of changes. Each PR in the stack builds on the one below it.
plugin-manifest-definition